Remove deltaTime from Fade and AutoScroll.

davidjerleke · Nov 17, 2024 · 76d3efd · 76d3efd
1 parent afdf97a
commit 76d3efd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/packages/embla-carousel-auto-scroll/src/components/AutoScroll.ts b/packages/embla-carousel-auto-scroll/src/components/AutoScroll.ts
@@ -164,15 +164,14 @@ function AutoScroll(userOptions: AutoScrollOptionsType = {}): AutoScrollType {
     let rawLocationPrevious = 0
     let hasSettled = false
 
-    function seek(timeStep: number): ScrollBodyType {
-      const fixedDeltaTimeSeconds = timeStep / 1000
+    function seek(): ScrollBodyType {
       let directionDiff = 0
 
       previousLocation.set(location)
 
-      bodyVelocity = directionSign * options.speed * 55
+      bodyVelocity = directionSign * options.speed
       rawLocation += bodyVelocity
-      location.add(bodyVelocity * fixedDeltaTimeSeconds)
+      location.add(bodyVelocity)
       target.set(location)
 
       directionDiff = rawLocation - rawLocationPrevious

diff --git a/packages/embla-carousel-fade/src/components/Fade.ts b/packages/embla-carousel-fade/src/components/Fade.ts
@@ -20,7 +20,6 @@ function Fade(userOptions: FadeOptionsType = {}): FadeType {
   const fullOpacity = 1
   const noOpacity = 0
   const fadeFriction = 0.68
-  const timeStep = 1000 / 60
 
   let emblaApi: EmblaCarouselType
   let opacities: number[] = []
@@ -218,9 +217,8 @@ function Fade(userOptions: FadeOptionsType = {}): FadeType {
 
   function fade(emblaApi: EmblaCarouselType): void {
     const { dragHandler, scrollBody } = emblaApi.internalEngine()
-    const fixedDeltaTimeSeconds = timeStep / 1000
     const pointerDown = dragHandler.pointerDown()
-    const velocity = scrollBody.velocity() * fixedDeltaTimeSeconds
+    const velocity = scrollBody.velocity()
     const duration = scrollBody.duration()
     const fadeIndex = getFadeIndex()
     const noFadeIndex = !isNumber(fadeIndex)