Merge pull request #1012 from suraj776/bug/#1009

[Bug]: TypeError: Cannot read properties of undefined (reading 'map') in AutoHeight
davidjerleke · Sep 24, 2024 · 2af08af · 2af08af
2 parents 4ebb8c3 + 0a6772c
commit 2af08af
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/packages/embla-carousel-auto-height/src/components/AutoHeight.ts b/packages/embla-carousel-auto-height/src/components/AutoHeight.ts
@@ -43,16 +43,21 @@ function AutoHeight(userOptions: AutoHeightOptionsType = {}): AutoHeightType {
     if (!container.getAttribute('style')) container.removeAttribute('style')
   }
 
-  function highestInView(): number {
+  function highestInView(): number | null {
     const { slideRegistry } = emblaApi.internalEngine()
     const selectedIndexes = slideRegistry[emblaApi.selectedScrollSnap()]
 
+    if (!selectedIndexes) return null
+
     return selectedIndexes
       .map((index) => slideHeights[index])
       .reduce((a, b) => Math.max(a, b), 0)
   }
 
   function setContainerHeight(): void {
+    const height = highestInView()
+    if (height === null) return
+
     emblaApi.containerNode().style.height = `${highestInView()}px`
   }