-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: multiple hash loader with different color renders as the same color #602
Conversation
This seems to break the snapshot tests as the animation strings are injected and they are used for summary hashes of CSS classes. Can we use something else for the suffix generation like a hash function? |
this has been reverted and published as 0.14.1. i think a hashing function make sense. using the color prop as part of the hash should solve this issue |
Thanks for the revert! |
What changes are introduced?
fixes #581
generate a random hash when creating animation keyframe
Any screenshots?