Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple hash loader with different color renders as the same color #602

Merged
merged 6 commits into from
Jun 26, 2024

Conversation

davidhu2000
Copy link
Owner

What changes are introduced?

fixes #581

generate a random hash when creating animation keyframe

Any screenshots?

Screenshot 2024-06-24 at 10 47 00 AM

@davidhu2000 davidhu2000 changed the title fix-hash fix: multiple hash loader with different color renders as the same color Jun 24, 2024
@davidhu2000 davidhu2000 merged commit ae4a2c5 into main Jun 26, 2024
5 checks passed
@davidhu2000 davidhu2000 deleted the fix-hash branch June 26, 2024 05:01
@raviqqe
Copy link

raviqqe commented Jun 26, 2024

This seems to break the snapshot tests as the animation strings are injected and they are used for summary hashes of CSS classes. Can we use something else for the suffix generation like a hash function?

@davidhu2000
Copy link
Owner Author

This seems to break the snapshot tests as the animation strings are injected and they are used for summary hashes of CSS classes. Can we use something else for the suffix generation like a hash function?

this has been reverted and published as 0.14.1. i think a hashing function make sense. using the color prop as part of the hash should solve this issue

@raviqqe
Copy link

raviqqe commented Jun 29, 2024

Thanks for the revert!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HashLoader color is taken from the last HashLoader component
2 participants