Skip to content

Conversation

akbarcandra
Copy link
Contributor

@akbarcandra akbarcandra commented Nov 9, 2019

Checklist:

  • Add form url encoded body option
  • Add raw body option (text & JSON) using CodeMirror
  • Refactor request tabs component to use sync modifier for request prop

Preview
image
image
image
image

@davidhsianturi
Copy link
Owner

@akbarcandra thanks for sending this in! It's been pretty hectic for me lately so it might be a while before I get to this. But I haven't forgotten about it yet, just so you know :)

@akbarcandra
Copy link
Contributor Author

Okay no problem

@davidhsianturi
Copy link
Owner

@akbarcandra this is nice additions and the API call still works like a charm 👍
I noticed that you are using the same table row in different form options,
are we expecting this UX?
Nov-17-2019 23-19-55

@akbarcandra
Copy link
Contributor Author

@akbarcandra this is nice additions and the API call still works like a charm 👍
I noticed that you are using the same table row in different form options,
are we expecting this UX?
Nov-17-2019 23-19-55

Hmm, you right, that will cause a problem if using same table row for different form options, especially for File value. I will try to fix this by separating it.

@akbarcandra
Copy link
Contributor Author

@davidhsianturi have you tried to test for Raw options? Especially for XML, YAML, EDN. Is it working to be received by an API? If it is to hard to test, I can remove that feature for this PR and put in another PR.

@davidhsianturi
Copy link
Owner

Hmm, you right, that will cause a problem if using same table row for different form options, especially for File value. I will try to fix this by separating it.

Maybe you can add the identifier like id to the raw? the raw table should be unique I guess

@davidhsianturi
Copy link
Owner

davidhsianturi commented Nov 18, 2019

@davidhsianturi have you tried to test for Raw options? Especially for XML, YAML, EDN. Is it working to be received by an API? If it is to hard to test, I can remove that feature for this PR and put in another PR.

right, I think we just need the JSON options for now.

@akbarcandra
Copy link
Contributor Author

Hi @davidhsianturi , I already push some fixes, please to review, thanks 😊

@davidhsianturi davidhsianturi merged commit 554529a into davidhsianturi:master Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants