Skip to content

Conversation

@JesseKolb
Copy link
Contributor

The TICC object will save its data in self.trained_model because it seemed the current output of fit(), train_cluster_inverse , is not enough by itself to predict for new data. Once fit, the predict_clusters method can be used to predict clusters on new data by passing it in as an argument.

I just added 2 basic tests using this as examples, but I'm not sure if it'd be best to refactor the unit tests, since I just added it to one of your tests. I think it'd be good to add more unit tests as well going forward, as well as perhaps some short docstrings to some of the functions which are hard to understand without context (e.g. upper2Full and Prox_logdet)

@davidhallac
Copy link
Owner

The predict_clusters method looks great - thanks!

The unit tests look good, though yes, we are hoping to revamp our unit tests in the near future to be a lot more comprehensive/robust (we initially just added small unit tests to integrate a few new changes we were making to the code, but as more people use TICC, I agree that we need to refactor and continue to improve them)

@davidhallac davidhallac merged commit 5788a14 into davidhallac:master May 4, 2018
@JesseKolb JesseKolb deleted the predict_new_data branch May 4, 2018 17:16
@heastdream
Copy link

It is hard to understand the function of upper2Full and Prox_logdet in admm_solver.py, can you give me some help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants