change convergence to be before point reassignment, change point reas… #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…signment to use updated point lengths
This is a relic from the original iteration of ticc: we used to move points before updating the cluster (which didn't do anything since we would then promptly reassign the points anyway). When we moved the empty cluster reassignment down to after the point updates, forgot to change the method to recalculate lengths.
Also, when checking for convergence, we should check before moving empty points to avoid oscillations where the algorithm has converged, but it just converged on an outcome we don't like (i.e empty clusters).