Skip to content

Add cancel and complete #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Add cancel and complete #129

wants to merge 7 commits into from

Conversation

adamradocz
Copy link
Contributor

Add CompleteAsync and CancelPending to the Protocols.

@adamradocz
Copy link
Contributor Author

@davidfowl I just realised that, this PR also contains the modifications of #124. Do you want me separate it from that one?

Other:
Related to #127, I'd like to make a PR that updates the client sample app to show how to disconnect from the server. Is that OK with you? Just asking, because this repo seems abandoned to me.

@adamradocz adamradocz mentioned this pull request Dec 11, 2021
Open
davidfowl
davidfowl reviewed Dec 11, 2021
View reviewed changes
src/Bedrock.Framework.Experimental/Bedrock.Framework.Experimental.csproj
</ItemGroup>

<ItemGroup>
<PackageReference Update="Nerdbank.GitVersioning" Version="3.4.244" />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this here?

Copy link
Contributor Author

@adamradocz adamradocz Dec 12, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is in the master too. I just updated it.

BedrockFramework/version.json

Line 2 in f69fa1b

"$schema": "https://raw.githubusercontent.com/AArnott/Nerdbank.GitVersioning/master/src/NerdBank.GitVersioning/version.schema.json",

BedrockFramework/Directory.Build.props

Line 14 in f69fa1b

<PackageReference Include="Nerdbank.GitVersioning">

davidfowl
davidfowl reviewed Dec 11, 2021
View reviewed changes
src/Bedrock.Framework.Experimental/Protocols/Http1RequestMessageReader.cs

case State.Headers:
while (sequenceReader.TryReadTo(out var headerLine, NewLine))
while (sequenceReader.TryReadTo(out ReadOnlySequence<byte> headerLine, NewLine))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On .NET 6 you get the following error when you use the var:

Error	CS0121	The call is ambiguous between the following methods or properties: 
'SequenceReader<T>.TryReadTo(out ReadOnlySequence<T>, ReadOnlySpan<T>, bool)' and
'SequenceReader<T>.TryReadTo(out ReadOnlySpan<T>, ReadOnlySpan<T>, bool)'

davidfowl
davidfowl reviewed Dec 11, 2021
View reviewed changes
src/Bedrock.Framework.Experimental/Protocols/Http1ResponseMessageReader.cs

case State.Headers:
while (sequenceReader.TryReadTo(out var headerLine, NewLine))
while (sequenceReader.TryReadTo(out ReadOnlySequence<byte> headerLine, NewLine))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo

Copy link
Contributor Author

@adamradocz adamradocz Dec 12, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On .NET 6 you get the following error when you use the var:

Error	CS0121	The call is ambiguous between the following methods or properties: 
'SequenceReader<T>.TryReadTo(out ReadOnlySequence<T>, ReadOnlySpan<T>, bool)' and
'SequenceReader<T>.TryReadTo(out ReadOnlySpan<T>, ReadOnlySpan<T>, bool)'

davidfowl
davidfowl reviewed Dec 11, 2021
View reviewed changes
davidfowl
davidfowl reviewed Dec 11, 2021
View reviewed changes
src/Bedrock.Framework/Bedrock.Framework.csproj
</ItemGroup>

<ItemGroup>
<PackageReference Update="Nerdbank.GitVersioning" Version="3.4.244" />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be here.

Copy link
Contributor Author

@adamradocz adamradocz Dec 12, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is in the master too. I just updated it.

BedrockFramework/version.json

Line 2 in f69fa1b

"$schema": "https://raw.githubusercontent.com/AArnott/Nerdbank.GitVersioning/master/src/NerdBank.GitVersioning/version.schema.json",

BedrockFramework/Directory.Build.props

Line 14 in f69fa1b

<PackageReference Include="Nerdbank.GitVersioning">

@adamradocz adamradocz mentioned this pull request Dec 14, 2021
Closed
@adamradocz adamradocz requested a review from davidfowl December 14, 2021 12:14
@adamradocz adamradocz closed this Feb 11, 2022
@adamradocz adamradocz mentioned this pull request Feb 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfowl davidfowl Awaiting requested review from davidfowl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamradocz @davidfowl