fix(globals)!: disabled $_REQUEST super global function
#332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm ok to merge it for now, as we're waiting for the maintainers answer. |
|
Ye, wanted to wait for some info in the issue before putting in more work. Seeing the problematic pipelines pass was enough for a first throw. Will add links to the issue here and on php side as well. |
BREAKING CHANGE: If you used `http_request_vars()` before it will now panic until a proper implementation is found. Refs: #331
|
@ptondereau fixed the issue and added docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a test for now. Goal is fixing CI. If merged with these changes:
BREAKING CHANGE: If you used
http_request_vars()before it will now panic until a proper implementation is found.Refs: #331