Add support for optional param names #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiriChara
force-pushed
the
feature/optional-params
branch
from
d7405c0 to
f6a27a0
Compare
| end | ||
|
|
||
| define_method "#{method_name}=" do |param| | ||
| if param.is_a?(Symbol) |
There was a problem hiding this comment.
Hmm I think since params is a HashWithIndifferentAccess (or, in Grape's case, a Hashie::Mash ¯_(ツ)_/¯), a String should also be fine here
|
Nice work here, @JiriChara! I really like the solution you came up with. If you could just fix that one issue I mentioned above, I'm more than happy to merge this in |
api-pagination is using the params[:page] and params[:per_page] parameters by default, but it would be better to make that configurable and that's what this commit is about.
JiriChara
force-pushed
the
feature/optional-params
branch
from
f6a27a0 to
b81d36e
Compare
|
Thanks @davidcelis! I am happy to help :-). I have fixed the issue you mentioned. |
davidcelis
added a commit
that referenced
this pull request
Feb 24, 2016
Add support for optional param names
|
Thanks a ton! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api-pagination uses
params[:page]andparams[:per_page]to set the current page and per-page options in the controller by default. This commit allows user to actually override those and use their own getters or specify the name of the parameter. So they can use for exampleparams[:page][:number]for current page by default.No breaking changes (just one more feature)