Cross-platform remove dist folder using rimraf in build script #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to build the package on a Windows system using
npm run build
. This however gave me the following error:This happened because the build script currently uses the unix command
rm
to remove thedist
folder which doesn't exist on Windows.I have replaced it with
rimraf
which allows us to remove the directory regardless of the platform we're developing on. This however introduces a new library and I'm not sure whether this is acceptable or not, so please let me know 😃