Skip to content

remove newlines from non-line-indented output #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2023

Conversation

jonathanmorley
Copy link
Contributor

No description provided.

@jonathanmorley
Copy link
Contributor Author

Closes #43

@poszu
Copy link

poszu commented Jul 7, 2022

@davidbarsky, what is holding you back from merging this?

@oli-obk
Copy link
Collaborator

oli-obk commented Apr 17, 2023

Sorry, I forgot to subscribe to this repo, so I didn't see any notification. I'm supposed to be maintaining this at present.

@jonathanmorley
Copy link
Contributor Author

I am not sure of the intent behind 6e565e6. It appears to me that this introduced a bug where some extra indentation happens on certain lines but not others.

With no-indent-lines, this extra indentation is ambiguous as to whether it is introducing a real indent level or not.

@oli-obk
Copy link
Collaborator

oli-obk commented May 19, 2023

The tests don't show this, but if you run the examples locally you can see that all the timestamps are padded in a way to always be of the same length (until you get to > 60 minutes). The tests strip the timestamps, so that's why they look weird.

@jonathanmorley
Copy link
Contributor Author

I see, I have made #61 so that the tests can show this

@oli-obk
Copy link
Collaborator

oli-obk commented May 19, 2023

Thanks! That's a lot better

@oli-obk
Copy link
Collaborator

oli-obk commented May 22, 2023

Please rebase this PR on top of the main branch so we can see the difference your other PR makes to this one

@oli-obk oli-obk merged commit 483cc0a into davidbarsky:main May 23, 2023
@jonathanmorley jonathanmorley deleted the remove-newlines branch May 23, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants