-
Notifications
You must be signed in to change notification settings - Fork 32
remove newlines from non-line-indented output #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Closes #43 |
@davidbarsky, what is holding you back from merging this? |
Sorry, I forgot to subscribe to this repo, so I didn't see any notification. I'm supposed to be maintaining this at present. |
e245e32
to
e033e68
Compare
I am not sure of the intent behind 6e565e6. It appears to me that this introduced a bug where some extra indentation happens on certain lines but not others. With no-indent-lines, this extra indentation is ambiguous as to whether it is introducing a real indent level or not. |
The tests don't show this, but if you run the examples locally you can see that all the timestamps are padded in a way to always be of the same length (until you get to > 60 minutes). The tests strip the timestamps, so that's why they look weird. |
I see, I have made #61 so that the tests can show this |
Thanks! That's a lot better |
Please rebase this PR on top of the main branch so we can see the difference your other PR makes to this one |
e033e68
to
396a36b
Compare
No description provided.