forked from zed-industries/zed
-
Notifications
You must be signed in to change notification settings - Fork 0
Davidagold/jupyter #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
davidagold
wants to merge
44
commits into
main
Choose a base branch
from
davidagold/jupyter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Work on outputs * Work * Produce cell output buffers * Bugfix, but we're still seeing no outputs * Better way to do syntax highlighting * Didn't mean to comment that * Clean up a bit * (Some) Output cells print * Remove commented code * Aesthetics * Error forwarding utility and cleanup * Simple outputs display
* Remove duplicate Cargo deps entry and sort * Moving along * Progress (exclamation point) * More progress * I don't think things will work this way. * Horrendous state but some progress I think * I think this will do * A little cleanup * Work testing code execution * Work testing code execution * Work testing code execution * Now we're talking (exclamation point) * Kernel connection * Reorganize a little bit * test_server.py -> src/jupyter/connection.py
* Superfluous change that was nonetheless bugging me * Fill out, consolidate Cells initialization and SumTree dimensions * Commit work while I try to undo accidental find+replace-all * Work on updating outputs * Include Python modules * Small post-rebase fixes * Progress on adding new cell * Checkpoint * We can insert cells * We can insert cells * Wow that took much longer than expected * Get current cell ID from buffer * Include cell ID in KernelMessage event * Remove stale output of current cell when run * IT WORKS * Clean up a little bit
Mark output when execution successful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes:
Optionally, include screenshots / media showcasing your addition that can be included in the release notes.
Or...
Release Notes: