Skip to content

Conversation

kkartal
Copy link

@kkartal kkartal commented Jun 12, 2024

There isn't any listener for verificationCode.

  • onSubmit is triggered when verificationCode matches the predefined conditions.
  • onCodeChange gives only the latest char.

I added onVerificationCodeChanged and it's triggered when verificationCode is changed. null values are filtered, so, this function returns only non-null values.

@kkartal
Copy link
Author

kkartal commented Jun 21, 2024

I wanted to clear all fields when user types wrong code.

  • There is a "clearText" flag currently but it does not work properly and efficiently. Also, it's for manual update.

I added a flag if the code will be deleted when the onSubmit function is called.

@kkartal kkartal changed the title Listener for verification code OnVerificationCodeChanged listener and ClearOnSubmit flag Jun 21, 2024
@kkartal kkartal requested a review from ainulbedjo June 21, 2024 11:08
Copy link

@ainulbedjo ainulbedjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants