Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Qt.py as an external dependancy #156

Closed
david-cattermole opened this issue Sep 16, 2020 · 3 comments
Closed

Remove Qt.py as an external dependancy #156

david-cattermole opened this issue Sep 16, 2020 · 3 comments
Assignees
Labels
builld system Related to the Build system for the project. user interface Related to a User Interface (Maya or Qt)
Milestone

Comments

@david-cattermole
Copy link
Owner

Problem

The Qt.py is currently an external dependency, and is currently installed in the PYTHON_PATH globally.

This is not ideal, since our Qt.py version may override or conflict with the currently installed version.

Instead, we should ensure the Qt.py version used in mmSolver is an internal dependency and is installed at import mmSolver.Qt.QtGui as QtGui, rather than outside mmSolver (import Qt.QtGui as QtGui)

Software Versions

This change will be made in a minor version update - not a patch level update.

  • mmSolver version: v0.4.0
  • Maya version: All
  • Operating System (OS): All
@david-cattermole david-cattermole added builld system Related to the Build system for the project. user interface Related to a User Interface (Maya or Qt) labels Sep 16, 2020
@david-cattermole david-cattermole added this to the v0.4.0 milestone Sep 16, 2020
@david-cattermole david-cattermole self-assigned this Sep 16, 2020
@david-cattermole
Copy link
Owner Author

As a really good guide on how I should have included Qt.py from the beginning, here is an article;
https://fredrikaverpil.github.io/2017/05/04/vendoring-qt-py/

@david-cattermole
Copy link
Owner Author

We've had a bug caused by using an old Qt.py version; #215.

The safest thing to do is include Qt.py inside mmSolver.
I think we should just do it for v0.3.x and change the install process rather than:

a) make our build process more complicated by upgrading to Qt.py 1.2.0 only on Maya 2020, or

b) update to Qt.py for all Maya versions (including older versions).

David

@david-cattermole david-cattermole modified the milestones: v0.4.0, v0.3.14 Apr 10, 2021
david-cattermole added a commit that referenced this issue Jul 4, 2021
Qt.py is now included inside mmSolver and can be removed as an external
dependency.

Issue #156.
@david-cattermole
Copy link
Owner Author

Qt.py has now been embedded into mmSolver at mmSolver.ui.Qt. All files using Qt.py have been updated to the new path, and this has been pushed to the build_issue156 branch, then merged into develop_v0.3.x.

This update will be released in v0.3.14. Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builld system Related to the Build system for the project. user interface Related to a User Interface (Maya or Qt)
Projects
None yet
Development

No branches or pull requests

1 participant