Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core Solver - Investigate optimal "dgdirty" usage #102

Closed
david-cattermole opened this issue May 18, 2019 · 2 comments
Closed

Core Solver - Investigate optimal "dgdirty" usage #102

david-cattermole opened this issue May 18, 2019 · 2 comments
Assignees
@david-cattermole
Labels
core solver Related to the low-level solver functions.
Milestone
v0.3.0

Comments

@david-cattermole
Copy link
Owner

Description

Maya MEL "dgdirty" commands in the internal solver iteration function.
The current uses the command "dgdirty -allPlugs -implicit;" twice at each evaluation.
"dgdirty" was added to the evaluation function in an attempt to enforce correctness.

We should investigate the use of this command, and see if disabling (or changing the flags) can help improve performance, while maintaining accuracy.

Notes

  • We must be careful to test in both the GUI and Maya Batch (mayapy) sessions.
@david-cattermole david-cattermole added the core solver Related to the low-level solver functions. label May 18, 2019
@david-cattermole david-cattermole added this to the v0.3.0 milestone May 18, 2019
@david-cattermole david-cattermole self-assigned this May 18, 2019
@david-cattermole david-cattermole changed the title Core Solver - Investgate optimal "dgdirty" usage Core Solver - Investigate optimal "dgdirty" usage May 18, 2019
david-cattermole added a commit that referenced this issue May 19, 2019
@david-cattermole
Add explicit node names to dgdirty command.
f079c64 
Remove second dgdirty command.
Added a cache of Maya's current state (interactive or batch).
Removal of unused FABS macro.
Issue #102.
@david-cattermole
Copy link
Owner Author

This latest commit does not seem to cause any decrease in accuracy, but performance should be tested with and without the commit.

This commit has not been merged into master. It will be merged once tests prove this to be faster and just as accurate.

david-cattermole added a commit that referenced this issue Jun 30, 2019
@david-cattermole
Changed DG Update ON by default, the performance drop is not measurab…
35f78cc 
…le. Issue #102.
david-cattermole added a commit that referenced this issue Jun 30, 2019
@david-cattermole
Fixed test solve to achieve below 1.0 pixel deviation, by locking bun…
31c868e 
…dles (treated as survey). Issue #102.
@david-cattermole
Copy link
Owner Author

This has been tested and found DG Dirty commands (as slightly changed in this issue) does not cause a large performance difference (the difference does not seem measurable),

Forcing DG Dirty as part of the Solver UI is now on by default.

A Solver test has also been optimised to solve quickly and accurately.

This is merged into the master branch.

@david-cattermole david-cattermole mentioned this issue Sep 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@david-cattermole david-cattermole

Labels
core solver Related to the low-level solver functions.
Projects
None yet
Milestone
v0.3.0
Development

No branches or pull requests
1 participant
@david-cattermole