Skip to content

Work around likely Textual bug with OptionList #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

TomJGooding
Copy link
Contributor

This looks like a possible bug in Textual, but currently some of the separator lines are missing depending on the width of the terminal.

Setting scrollbar-gutter: stable seems to fix this issue.

This looks like a possible bug in Textual, but currently some of the
separator lines are missing depending on the width of the terminal.

Setting `scrollbar-gutter: stable` seems to fix this issue.
@TomJGooding
Copy link
Contributor Author

Before

before

After

after

@davep
Copy link
Owner

davep commented Jan 25, 2025

This looks like a possible bug in Textual, but currently some of the separator lines are missing depending on the width of the terminal.

Yeah, I've been trying to chase down a reliable recreation of this since I started work on Braindrop back in December; it's an issue that's been plaguing me with that and also with this. It seems to be another one of those things that has turned up as an issue in later versions of Textual (0.86 seems to have broken a heck of a lot of stuff; and it also looks like someone decided to "improve" OptionList by breaking a bunch of things too).

@davep davep changed the title fix(peps view): fix missing separators Work around likely Textual bug with OptionList Jan 25, 2025
@davep davep added Cosmetic All things relating to the look of the application Housekeeping General codebase housekeeping labels Jan 25, 2025
@davep davep merged commit 7050c66 into davep:main Jan 25, 2025
6 checks passed
davep added a commit that referenced this pull request Jan 25, 2025
davep added a commit that referenced this pull request Jan 25, 2025
@TomJGooding
Copy link
Contributor Author

This is definitely a bug that is annoying to try to reproduce. It took a bit of experimentation to realise the scrollbar was the cause. Unless you beat me to it, I might try making a MRE myself so this can reported as an issue in Textual.

Speaking of which, reading through some your comments almost caused me to exhale beer through my nose. You're lucky that you don't owe me a new laptop.

@TomJGooding TomJGooding deleted the fix-peps-view-fix-missing-separators branch January 25, 2025 22:10
@davep
Copy link
Owner

davep commented Jan 25, 2025

Go for it. I've absolutely failed to create an MRE and it sounds like you've got far closer to narrowing down than I have.

Glad someone reads comments. 🙂

@TomJGooding
Copy link
Contributor Author

I'll have a go. There's some big shoes to fill, I'm just not the right size and missing a few feet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cosmetic All things relating to the look of the application Housekeeping General codebase housekeeping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants