Stop exceptions from causing an infinite loop. #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies insert Atomic to return the result of the action argument, if it's available. If the result is an exception, lookupOrLoad will now raise the exception rather than recursing (thus stopping the loop). If I did it right, the behavior of lookupOrLoad otherwise should almost be the same as before. The only other difference should be how the general exit case is handled in insertAtomic. If we get an exception other than the cancelled case, we'll raise that as well in lookupOrLoad. (Not sure what other errors can arise here other than maybe fatal ones, since the other operations are wrapped in attempts).
The test "only run till errors cease" is now broken, since that behavior is changed different here and I'm not sure what you want the test to look like now.
Fixes #330