make winctl compatible with electron v20 and above #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to various reports there are currently two major issues that cause electron apps (after v20) to conflict with native modules.
1.) deprecated
AccessorSignaturesas per nodejs/nan#943 - This issue is fixed by a fix in the nan module, it hasn't been merged and released yet. I tested it by installing nan fromhttps://github.com/weedz/nan/commit/a679b69b92e1997f6b40f1d3981a58a0021e1b99and winctl builds with this patch.2.)
CreationContextis no longer supported. According to WiseLibs/better-sqlite3#858 (comment) this can be fixed by replacingCreationContext()withGetCreationContext().ToLocalChecked().The latter was implemented here. With the upcoming release of a new nan version the first issue should "fix itself" :-) winctl should then be fully compatible with electron v20 and newer.