Skip to content

Conversation

@shubham-dogra-s1
Copy link

No description provided.

@shubham-dogra-s1
Copy link
Author

@daveleroy can you review this pr? Thanks!

@daveleroy
Copy link
Owner

This PR doesn't really follow what vscode has implemented with their task system it. It basically locks me into supporting your one off use case instead of actually implementing a general feature like watch tasks in vscode which seems to support what you want and a ton of other more useful features.

@shubham-dogra-s1
Copy link
Author

shubham-dogra-s1 commented Sep 23, 2025

Don't agree with you, we are not building a copy of vscode tasks system that should come natively from sublime text.

This is very general problem where I want debugger to start as soon as my build task gives me certain active signal.

What vs code have is

  • File watcher that rerun's the build task as soon as something changes.
  • pattern support for problem matching not very useful here as well

This is not very useful in debugging as we are defining a preBuild task. If anything changes you need to restart the debugger again

@daveleroy
Copy link
Owner

Don't agree with you, we are not building a copy of vscode tasks system that should come natively from sublime text.

I don't know what to tell you here... basically all the features in vscode tasks are required to have robust pre/post debug task support. Background tasks (watchers), sequenced tasks, parallel tasks, canceling tasks via other tasks etc are all relevant features. Things like auto detected npm/gradlew/etc tasks are also nice.

All these features fit together and work for both debug tasks and normal tasks.

You aren't looking at the whole picture you are just focused on solving your issue and not taking into account other use cases. If you come up with an actual design that covers all the common cases be my guest but you will just end up with a very similar feature set as vscode.

pattern support for problem matching not very useful here as well

Compiling stuff shouldn't have problem matching? Build tasks followed by watcher build tasks are probably the most common use case for a pre debug task.

File watcher that rerun's the build task as soon as something changes.

Having a watcher as a pre debug background task is one of the main reasons background tasks exist.

If anything changes you need to restart the debugger again

This isn't true it depends on the adapter/project and you don't want your background watcher task cancelled because you stopped debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants