You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello there,
Python str.join method accepts any kind of iterable object so, you could use a generator expression here. However, it is not a big different.
Hi @GreatBahram,
You're absolutely right, thanks for the suggestion and this would be better. If we do another edition of the book, I will make the change. Because it would make this source code repository diverge from the code from the physical book for a non-error, though, I won't make the change at this time.
Best,
Dave
@davecom, You should create a branch or a fork that includes all enhancements. The master branch of this repository will be untouched and everybody has the option to use the enhanced version.
Activity
davecom commentedon Jul 26, 2019
Hi @GreatBahram,
You're absolutely right, thanks for the suggestion and this would be better. If we do another edition of the book, I will make the change. Because it would make this source code repository diverge from the code from the physical book for a non-error, though, I won't make the change at this time.
Best,
Dave
m-entrup commentedon Aug 7, 2019
@davecom, You should create a branch or a fork that includes all enhancements. The master branch of this repository will be untouched and everybody has the option to use the enhanced version.
davecom commentedon Aug 7, 2019
@m-entrup That's a good idea. I may do that in a branch in the future. Thanks!