Skip to content

Fix Unhandled Interrupted system call in PipeLoggerServer #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 2, 2022
Merged

Fix Unhandled Interrupted system call in PipeLoggerServer #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
279c90c
Fix Unhandled Interrupted system call in PipeLoggerServer (#8)
xoofx Feb 23, 2022
bb03a52
Fix problem with dangling reader/writer threads blocked on sockets th…
xoofx Feb 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/MsBuildPipeLogger.Logger/PipeWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ protected PipeWriter(PipeStream pipeStream)
_binaryWriter = new BinaryWriter(_memoryStream);
_argsWriter = new BuildEventArgsWriter(_binaryWriter);

new Thread(() =>
Thread writerThread = new Thread(() =>
{
BuildEventArgs eventArgs;
while ((eventArgs = TakeEventArgs()) != null)
Expand All @@ -46,7 +46,11 @@ protected PipeWriter(PipeStream pipeStream)
_pipeStream.Flush();
}
_doneProcessing.Set();
}).Start();
})
{
IsBackground = true,
};
writerThread.Start();
}

private BuildEventArgs TakeEventArgs()
Expand Down
11 changes: 8 additions & 3 deletions src/MsBuildPipeLogger.Server/PipeLoggerServer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ protected PipeLoggerServer(TPipeStream pipeStream, CancellationToken cancellatio
_buildEventArgsReader = new BuildEventArgsReaderProxy(_binaryReader);
CancellationToken = cancellationToken;

new Thread(() =>
Thread readerThread = new Thread(() =>
{
try
{
Expand All @@ -55,7 +55,7 @@ protected PipeLoggerServer(TPipeStream pipeStream, CancellationToken cancellatio
{
}
}
catch (EndOfStreamException)
catch (IOException)
{
// The client broke the stream so we're done
}
Expand All @@ -68,7 +68,12 @@ protected PipeLoggerServer(TPipeStream pipeStream, CancellationToken cancellatio
Buffer.Write(new byte[1] { 0 }, 0, 1);

Buffer.CompleteAdding();
}).Start();
})
{
IsBackground = true
};

readerThread.Start();
}

protected abstract void Connect();
Expand Down