Skip to content

Update fork #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 17, 2019
Merged

Update fork #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e6afce0
Fix nightly (#545)
MarcoRossignoli Sep 16, 2019
41511a4
Hide report generator strong name warning on build (#546)
MarcoRossignoli Sep 16, 2019
903f61b
Move log to verbose for automatic excluded instrumented libs (#548)
MarcoRossignoli Sep 16, 2019
2aa8ed6
Update guide for inproc collector (#535)
MarcoRossignoli Sep 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ After the above command is run, a `coverage.cobertura.json` file containing the
See [documentation](Documentation/VSTestIntegration.md) for advanced usage.

#### Requirements
* _You need to be running .NET Core SDK v2.2.300 and above_
* _You need to be running .NET Core SDK v2.2.300 or newer_
* _To run fully-featured collectors ([see #110](https://github.com/tonerdo/coverlet/issues/110)) you need to be running .NET Core SDK v2.2.401 or newer_
* _You need to reference version 16.1.0 and above of Microsoft.NET.Test.Sdk_
```
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.1.0" />
Expand Down
2 changes: 1 addition & 1 deletion eng/azure-pipelines-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ pool:
steps:
- task: UseDotNet@2
inputs:
version: 2.2.300
version: 2.2.401
- powershell:
.\eng\nightly.ps1 -apiKey $env:APIKEY -source $env:SOURCE
ignoreLASTEXITCODE: true
Expand Down
4 changes: 2 additions & 2 deletions src/coverlet.core/Instrumentation/Instrumenter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public bool CanInstrument()
}
else
{
_logger.LogWarning($"Unable to instrument module: {_module}, embedded pdb without local source files, [{firstNotFoundDocument}]");
_logger.LogVerbose($"Unable to instrument module: {_module}, embedded pdb without local source files, [{firstNotFoundDocument}]");
return false;
}
}
Expand All @@ -88,7 +88,7 @@ public bool CanInstrument()
}
else
{
_logger.LogWarning($"Unable to instrument module: {_module}, pdb without local source files, [{firstNotFoundDocument}]");
_logger.LogVerbose($"Unable to instrument module: {_module}, pdb without local source files, [{firstNotFoundDocument}]");
return false;
}
}
Expand Down
4 changes: 2 additions & 2 deletions test/coverlet.core.tests/Instrumentation/InstrumenterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ public void SkipEmbeddedPpdbWithoutLocalSource()
Assert.True(_instrumentationHelper.HasPdb(xunitDll, out bool embedded));
Assert.True(embedded);
Assert.False(instrumenter.CanInstrument());
loggerMock.Verify(l => l.LogWarning(It.IsAny<string>()));
loggerMock.Verify(l => l.LogVerbose(It.IsAny<string>()));

// Default case
string coverletCoreDll = Directory.GetFiles(Directory.GetCurrentDirectory(), "coverlet.core.dll").First();
Expand All @@ -380,7 +380,7 @@ public void SkipPpdbWithoutLocalSource()
Assert.True(_instrumentationHelper.HasPdb(coverletLib, out bool embedded));
Assert.False(embedded);
Assert.False(instrumenter.CanInstrument());
loggerMock.Verify(l => l.LogWarning(It.IsAny<string>()));
loggerMock.Verify(l => l.LogVerbose(It.IsAny<string>()));
}

[Fact]
Expand Down
1 change: 1 addition & 0 deletions test/coverlet.core.tests/coverlet.core.tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<TargetFramework>netcoreapp2.0</TargetFramework>
<IsPackable>false</IsPackable>
<LangVersion>preview</LangVersion>
<NoWarn>$(NoWarn);CS8002</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down