Skip to content

Fix no animation when popping multiple items off the path #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 13, 2022
Merged

Fix no animation when popping multiple items off the path #44

merged 7 commits into from
Dec 13, 2022

Conversation

davdroman
Copy link
Owner

@davdroman davdroman commented Dec 13, 2022 •
edited
Loading

Fixes #41 by swizzling popToViewController(_:animated:) and forcing animated: true.

@davdroman davdroman enabled auto-merge (squash) December 13, 2022 22:17
@davdroman davdroman merged commit d319d7f into main Dec 13, 2022
@davdroman davdroman deleted the fix-pop-multiple-items-animation branch December 13, 2022 22:24
@davdroman davdroman mentioned this pull request Dec 14, 2022
Merged
davdroman added a commit that referenced this pull request Dec 14, 2022
@davdroman
Back-deploy fix for 96852321 (#45)
c076928 
Related to #41 and #44.

Makes sure to apply the workaround only on affected OSes. On OSes where
it's been fixed by Apple (iOS 16.2 and later), standard behaviour will
occur instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davdroman