Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ #53 , JSON output option ] #73

Merged
merged 3 commits into from
Nov 28, 2023
Merged

[ #53 , JSON output option ] #73

merged 3 commits into from
Nov 28, 2023

Conversation

mohamedsalem401
Copy link
Contributor

Write output fileObjects to .markdowndb/files.json # array of file objects

Copy link

changeset-bot bot commented Nov 27, 2023

🦋 Changeset detected

Latest commit: e8a7dcb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mddb Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@rufuspollock rufuspollock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd think we'd want a bit of docs here - both in README.md plus probably on the command line to explain that this happens.

I'd have also kept the code path for generating json separate from sqlite both in code and in command line (i probably don't want both).

src/lib/markdowndb.ts Show resolved Hide resolved
@mohamedsalem401
Copy link
Contributor Author

I'd have also kept the code path for generating json separate from sqlite both in code and in command line (I probably don't want both).

You mean to add an option to generate either SQL or JSON but not both simultaneously? Right?

@rufuspollock
Copy link
Member

I'd have also kept the code path for generating json separate from sqlite both in code and in command line (I probably don't want both).

You mean to add an option to generate either SQL or JSON but not both simultaneously? Right?

OK. I'm going to apply YAGNI and for now let's just generate both as you are doing. let's not bother with both paths.

@rufuspollock
Copy link
Member

@mohamedsalem401 the one thing to do is probably just to add a changeset and then we can merge as is for now.

@mohamedsalem401 mohamedsalem401 merged commit aedd641 into main Nov 28, 2023
3 checks passed
@mohamedsalem401 mohamedsalem401 deleted the json-output branch November 28, 2023 13:53
@github-actions github-actions bot mentioned this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants