-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ #53 , JSON output option ] #73
Conversation
🦋 Changeset detectedLatest commit: e8a7dcb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd think we'd want a bit of docs here - both in README.md plus probably on the command line to explain that this happens.
I'd have also kept the code path for generating json separate from sqlite both in code and in command line (i probably don't want both).
You mean to add an option to generate either SQL or JSON but not both simultaneously? Right? |
OK. I'm going to apply YAGNI and for now let's just generate both as you are doing. let's not bother with both paths. |
@mohamedsalem401 the one thing to do is probably just to add a changeset and then we can merge as is for now. |
Write output
fileObjects
to .markdowndb/files.json # array of file objects