Skip to content

Add endpoint options to Amazon S3 Storage #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rufuspollock merged 1 commit into from
Mar 30, 2022
Merged

Add endpoint options to Amazon S3 Storage #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions giftless/storage/amazon_s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ class AmazonS3Storage(StreamingStorage, ExternalStorage):
"""AWS S3 Blob Storage backend.
"""

def __init__(self, bucket_name: str, path_prefix: Optional[str] = None, **_):
def __init__(self, bucket_name: str, path_prefix: Optional[str] = None, endpoint: Optional[str] = None, **_):
self.bucket_name = bucket_name
self.path_prefix = path_prefix
self.s3 = boto3.resource('s3')
self.s3_client = boto3.client('s3')
self.s3 = boto3.resource('s3', endpoint_url=endpoint)
self.s3_client = boto3.client('s3', endpoint_url=endpoint)

def get(self, prefix: str, oid: str) -> Iterable[bytes]:
if not self.exists(prefix, oid):
Expand Down