-
Notifications
You must be signed in to change notification settings - Fork 37
Description
Hello again,
while trying to implement a reverse proxy that hides a regular git(hub) repo and giftless under one hostname for #128 (comment), I ran into some unfortunate endpoint rewriting needs that arise from the fact that giftless doesn't follow the automatic LFS server discovery. I.e. appending .git/info/lfs to the usual git repo URL for its endpoints. This gets worse when using the basic_streaming transfer adapter, which exposes the objects at <repopath>/objects/storage, which needs yet another routing rule which potentially shadows anything on that path in the git repo.
Giftless easily can (and I believe it should) natively play along with this and keep all its endpoints behind the <repopath>.git/info/lfs/ prefix. This would be much easier and cleaner to route, without really impacting any of the giftless functionality.
As such change would be a breaking one for current users, I believe we could govern this with a config variable like LEGACY_ENDPOINTS or so. On the other hand, this would surely bloat the testing code and as giftless hasn't seen a release for quite some time (I suppose most active users build it from main anyway), this could be a perfect material before the impending new release is dropped ;) After all, no api stability is to be expected for a tool with version starting with zero 😝
As usual, I have a PR ready 😉