Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sniff: now also sniffs if a file is utf-8 encoded #316

Merged
merged 6 commits into from
May 23, 2022
Merged

sniff: now also sniffs if a file is utf-8 encoded #316

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f1a87b6
use qsv-optimized fork of csv-sniffer
jqnatividad May 23, 2022
2666d36
cargo update bump
jqnatividad May 23, 2022
1c65f99
we also sniff is a file is utf8-encoded
jqnatividad May 23, 2022
1d0ff58
`sniff`: update tests to include is_utf8
jqnatividad May 23, 2022
da064f7
Expand UTF-8 Encoding section
jqnatividad May 23, 2022
ef67df9
this comment no longer applies
jqnatividad May 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
this comment no longer applies 
as csv-sniffer can now work with non UTF-8 encoded files
  • Loading branch information
@jqnatividad
jqnatividad committed May 23, 2022
commit ef67df97e17d9dad8d4998e46213a6e71a15da14
1 change: 0 additions & 1 deletion src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ impl Config {
);
}
Err(e) => {
// most likely, the file is not utf8 encoded
// we only warn, as we don't want to stop processing the file
// if sniffing doesn't work
warn!("sniff error: {e}");
Expand Down