fix(mongodb): SRV ReadPreference decoupling & config robustness#950
Open
siiddhantt wants to merge 2 commits into
Open
fix(mongodb): SRV ReadPreference decoupling & config robustness#950siiddhantt wants to merge 2 commits into
siiddhantt wants to merge 2 commits into
Conversation
…nce documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #682 - MongoDB SRV ReadPreference bug
This PR decouples the
read_preferencelogic from thereplica_setfield in the MongoDB driver config. Previously,read_preferencewas only set ifreplica_setwas non-empty, which broke SRV/Atlas connections and caused silent misconfigurations. Now,read_preferenceis always respected if provided, regardless ofreplica_setorsrvmode. Also fixes hyphenated JSON keys in docs/tests, and clarifies SRV/replica set usage in documentation.Type of change
How Has This Been Tested?
config_test.goScreenshots or Recordings
Documentation
Related PR's (If Any):
Checklist: