Skip to content

feat: add AutoScroll Feature #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: staging
Choose a base branch
from
Open

feat: add AutoScroll Feature #229

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5b06df8
Merge pull request #225 from datazip-inc/staging
vikaxsh Oct 7, 2025
81ede4f
Update JobLogs.tsx
Smartmind12 Oct 11, 2025
ca97840
Merge pull request #1 from Smartmind12/Smartmind12-patch-1
Smartmind12 Oct 11, 2025
82db39f
Merge branch 'staging' into my-feature
Smartmind12 Oct 11, 2025
2ee1d29
Update JobLogs.tsx
Smartmind12 Oct 17, 2025
d7af6d0
Merge branch 'staging' into my-feature
deepanshupal09-datazip Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion ui/src/modules/jobs/pages/JobLogs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useEffect, useState } from "react"
import { useEffect, useState, useRef } from "react"
import clsx from "clsx"
import { useParams, useNavigate, Link, useSearchParams } from "react-router-dom"
import { Input, Spin, message, Button, Tooltip } from "antd"
Expand Down Expand Up @@ -36,6 +36,8 @@ const JobLogs: React.FC = () => {
fetchJobs,
} = useAppStore()

const logContainerRef = useRef<HTMLDivElement>(null)

useEffect(() => {
if (!jobs.length) {
fetchJobs()
Expand All @@ -59,6 +61,16 @@ const JobLogs: React.FC = () => {
fetchJobs,
])

useEffect(() => {
if (logContainerRef.current && taskLogs.length > 0 && !isLoadingTaskLogs) {
const { scrollTop, scrollHeight, clientHeight } = logContainerRef.current
const isAtBottom = scrollHeight - scrollTop - clientHeight < 10
if (isAtBottom) {
logContainerRef.current.scrollTop = logContainerRef.current.scrollHeight
}
}
}, [taskLogs, isLoadingTaskLogs])

const job = jobs.find(j => j.id === Number(jobId))

const filteredLogs = taskLogs.filter(function (log) {
Expand Down Expand Up @@ -199,6 +211,7 @@ const JobLogs: React.FC = () => {
</div>
) : (
<div
ref={logContainerRef}
className={clsx(
"overflow-scroll rounded-xl bg-white",
filteredLogs.length > 0 && "border",
Expand Down
Loading