-
Notifications
You must be signed in to change notification settings - Fork 32
fix: replace deprecated Phosphor icons with latest *Icon alternatives #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
shubham19may
merged 13 commits into
datazip-inc:staging
from
Sarthak2845:fix/update-phosphor-icons
Oct 24, 2025
Merged
fix: replace deprecated Phosphor icons with latest *Icon alternatives #216
shubham19may
merged 13 commits into
datazip-inc:staging
from
Sarthak2845:fix/update-phosphor-icons
Oct 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
chore: staging -> master v0.1.6
Collaborator
|
Hi @Sarthak2845, please fix the linter errors and also update this branch. |
…and SourceEdit components and fix Lint issue
…k2845/olake-ui into fix/update-phosphor-icons
deepanshupal09-datazip
requested changes
Oct 23, 2025
Collaborator
deepanshupal09-datazip
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve this comment.
deepanshupal09-datazip
approved these changes
Oct 23, 2025
hash-data
added a commit
that referenced
this pull request
Oct 31, 2025
* feat: show error logs in test connection in source and destination * fix: fix test connection fail modal * fix: resolve comments * chore: add comments (#224) * chore: add comments * chore: 🚨 lint fix * feat: add error logs in check connection for source and destination (#195) * feat: add error logs i check conenction for source and destination * fix: parse json message as string * chore: update response key * chore: refactor * chore: remove logEntry struct * fix: log parsing * fix: log parsing * fix: logs parsing logic * docs: updated api contract * test: ✅ base setup for automation testing using play… (#203) * test: ✅ base setup for automation testing using playwright , add test cases fro major flows * fix: integration workflow changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * test: add postgres flow * fix: lint changes * test: add iceberg specific test * fix: tests * fix: stream name * fix: test fix * fix: test fix * fix: test fix * fix: test fix * fix: changes * fix: ci changes * fix: ci changes * fix: ci changes * test: fail test on test connection failure * fix: ci changes * fix: changes * fix: changes * fix: changes * fix: changes * fix: changes * fix: changes * fix: test fix * fix: changes * fix: changes * fix: test-data fix * fix: test-data fix * fix: changes * fix: changes * fix: changes * fix: host and port changes * fix: changes * fix: change * test: login test updated * test: refactor create source and destination page * test: refactor tests * fix: test fix * fix: changes * fix: fix changes * fix: changes * fix: changes * fix: review changes * refactor: refactor tests to use authenticated state of playwright * fix: changes * docs: update tests readme * test: intercept and log destination spec response * docs: update readme * fix: update timeouts for playwright tests * test: update readme * fix: add retries in playwright config * test: fix timeout duration * fix: update readme * test: add connector data test-id * fix: resolve comments * refactor(test): make and use enums instead of strings * fix: fix test data builder * fix: test data job name * fix: add todo --------- Co-authored-by: Duke Dhal <duke@datazip.io> Co-authored-by: deepanshupal09-datazip <deepanshu@datazip.io> * feat: show refetch success message in job history page (#227) * Added success message on Job History refetch * Update ui/src/modules/jobs/pages/JobHistory.tsx Co-authored-by: deepanshupal09-datazip <deepanshu@datazip.io> --------- Co-authored-by: vikash choudhary <vikash@datazip.io> Co-authored-by: deepanshupal09-datazip <deepanshu@datazip.io> * fix: replace deprecated Phosphor icons with latest *Icon alternatives (#216) * fix: replace deprecated Phosphor icons with latest *Icon alternatives * fix: update Phosphor icons to latest alternatives in DestinationEdit and SourceEdit components and fix Lint issue * refactor: remove EditSourceModal * fix: update icon import --------- Co-authored-by: vikash choudhary <vikash@datazip.io> * feat: add clear destination * fix: merge conflicts * fix: build error fix * feat: append only mode (#232) * feat: add append only mode in ui * fix: data filter bug * fix: fix color of append only mode switch * fix: add custom option in all streams ingestion mode change * fix: use clsx for conditional styling * fix: fix icons * chore: add utils --------- Co-authored-by: Taraka Swathi <swathi@datazip.io> Co-authored-by: Ankit Sharma <111491139+hash-data@users.noreply.github.com> Co-authored-by: vikash choudhary <vikash@datazip.io> Co-authored-by: Duke Dhal <duke@datazip.io> Co-authored-by: SARTHAK RANA <23510370.dit@dypvp.edu.in> Co-authored-by: vishalm0509 <vishal@datazip.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated all deprecated Phosphor icons used in the UI to their latest supported alternatives.
This ensures long-term compatibility, prevents warnings from outdated imports, and aligns the UI with the current Phosphor library updates.
Fixes: #197
Type of change
How Has This Been Tested?
Related PR's (If Any):
N/A