Skip to content

Go 1.24 #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .env.tools
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
export TOOLS_BUILDNUMBER=20250121.2

export TOOLS_BUILDNUMBER=20250415.2
10 changes: 0 additions & 10 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,3 @@ updates:
day: "tuesday"
time: "03:23"
timezone: "Europe/London"

# Maintain dependencies for go.mod
- package-ecosystem: "gomod"
directory: "/"
schedule:
interval: "weekly"
day: "tuesday"
time: "03:24"
timezone: "Europe/London"

10 changes: 6 additions & 4 deletions .github/workflows/push.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: '1.23'
go-version: '1.24'
cache: false

- name: Install Go quality tools
run: |
go install golang.org/x/tools/cmd/goimports@v0.1.7
go install github.com/axw/gocov/gocov@v1.1.0
go install github.com/jstemmer/go-junit-report/v2@v2.1.0
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.60.3
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.64.2

- name: Install Task
uses: arduino/setup-task@v2
Expand All @@ -31,17 +31,19 @@ jobs:

- name: Code quality checks
run: |
# Note: it is by design that we don't use the builder
task format
task lint

# If this produces any output, its will error. Formatting and linting changes should have
# been committed already.
git diff

- name: Vulnerability check
run: |
task vulncheck

- name: Unit tests
run: |
# Note: it is by design that we don't use the builder
task test:unit

- name: Integration tests
Expand Down
49 changes: 28 additions & 21 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,26 @@ linters-settings:
# Default: false
explicit-exhaustive-map: false
gci:
local-prefixes: github.com/datatrails/go-datatrails-merklelog
# Section configuration to compare against.
# Section names are case-insensitive and may contain parameters in ().
# The default order of sections is `standard > default > custom > blank > dot > alias > localmodule`,
# If `custom-order` is `true`, it follows the order of `sections` option.
# Default: ["standard", "default"]
sections:
- standard # Standard section: captures all standard packages.
- default # Default section: contains all imports that could not be matched to another section type.
- prefix(github.com/datatrails/avid) # Custom section: groups all imports with the specified Prefix.
- blank # Blank section: contains all blank imports. This section is not present unless explicitly enabled.
- dot # Dot section: contains all dot imports. This section is not present unless explicitly enabled.
- alias # Alias section: contains all alias imports. This section is not present unless explicitly enabled.
- localmodule # Local module section: contains all local packages. This section is not present unless explicitly enabled.
# Skip generated files.
# Default: true
skip-generated: false
# Enable custom order of sections.
# If `true`, make the section order the same as the order of `sections`.
# Default: false
custom-order: true
goconst:
min-len: 2
min-occurrences: 2
Expand All @@ -72,16 +91,16 @@ linters-settings:
min-complexity: 10
goimports:
local-prefixes: github.com/golangci/golangci-lint
golint:
min-confidence: 0
govet:
check-shadowing: true
enable-all: true
disable:
- fieldalignment
settings:
printf:
funcs:
- Infof
- Warnf
- Errorf
- Debugf
- Panicf
- Fatalf
lll:
line-length: 500
Expand All @@ -99,8 +118,6 @@ linters-settings:
# goconst - see ticket #3097
# goerr113 - disabled see https://github.com/Djarvur/go-err113/issues/10
# gofumpt - not useful - confusing messages
# gomnd - see ticket #3116
# govet - see ticket #3117
# nilreturn onwardis not yet evaluated...
# maligned - this guards against performance issues due to accessing
# mis-aligned structs. We don't have direct evidence of this being a
Expand All @@ -118,17 +135,17 @@ linters-settings:
linters:
enable-all: true
disable:
- canonicalheader
- containedctx
- contextcheck
- cyclop
- deadcode
- depguard
- dupl
- dupword
- durationcheck
- err113
- errchkjson
- errname
- exhaustivestruct
- exhaustruct
- forbidigo
- forcetypeassert
Expand All @@ -141,22 +158,16 @@ linters:
- gocyclo
- godot
- godox
- goerr113
- gofumpt
- golint
- gomoddirectives
- gomnd
- gosec
- gosimple
- ifshort
- inamedparam
- interfacer
- interfacebloat
- ireturn
- maligned
- maintidx
- mnd
- misspell
- mnd
- musttag
- nilerr
- nilnil
Expand All @@ -165,16 +176,13 @@ linters:
- nestif
- nolintlint
- nonamedreturns
- nosnakecase
- nosprintfhostport
- paralleltest
- perfsprint
- prealloc
- protogetter
- revive
- rowserrcheck
- scopelint
- structcheck
- stylecheck
- tagalign
- tagliatelle
Expand All @@ -186,7 +194,6 @@ linters:
- unparam
- unused
- usestdlibvars
- varcheck
- varnamelen
- wastedassign
- whitespace
Expand Down
7 changes: 6 additions & 1 deletion Taskfile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@ tasks:
cmds:
- task: codequality:lint

vulncheck:
desc: vulnerability check
cmds:
- task: codequality:vulncheck

go:modules:
desc: tidies the go modules
cmds:
Expand All @@ -60,4 +65,4 @@ tasks:
desc: run the unit tests
cmds:
- task: azurite:preflight
- task: gotest:go:azurite
- task: gotest:go:azurite
26 changes: 13 additions & 13 deletions go.mod
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
module github.com/datatrails/go-datatrails-logverification

go 1.23.0
go 1.24

require (
github.com/datatrails/go-datatrails-common v0.28.0
github.com/datatrails/go-datatrails-common-api-gen v0.7.0
github.com/datatrails/go-datatrails-merklelog/massifs v0.6.0
github.com/datatrails/go-datatrails-merklelog/mmr v0.4.0
github.com/datatrails/go-datatrails-merklelog/mmrtesting v0.4.0
github.com/datatrails/go-datatrails-common v0.30.0
github.com/datatrails/go-datatrails-common-api-gen v0.8.0
github.com/datatrails/go-datatrails-merklelog/massifs v0.6.2-0.20250428142544-72f502e82db0
github.com/datatrails/go-datatrails-merklelog/mmr v0.4.1
github.com/datatrails/go-datatrails-merklelog/mmrtesting v0.4.1
github.com/datatrails/go-datatrails-serialization/eventsv1 v0.0.2
github.com/datatrails/go-datatrails-simplehash v0.0.5
github.com/datatrails/go-datatrails-simplehash v0.2.0
github.com/google/uuid v1.6.0
github.com/stretchr/testify v1.10.0
github.com/veraison/go-cose v1.1.0
Expand All @@ -19,7 +19,7 @@ require (
require (
github.com/Azure/azure-sdk-for-go v68.0.0+incompatible // indirect
github.com/Azure/azure-sdk-for-go/sdk/azcore v1.17.0 // indirect
github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.7.0 // indirect
github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.8.2 // indirect
github.com/Azure/azure-sdk-for-go/sdk/internal v1.10.0 // indirect
github.com/Azure/azure-sdk-for-go/sdk/storage/azblob v0.4.1 // indirect
github.com/Azure/go-autorest v14.2.0+incompatible // indirect
Expand All @@ -32,7 +32,7 @@ require (
github.com/Azure/go-autorest/autorest/validation v0.3.1 // indirect
github.com/Azure/go-autorest/logger v0.2.1 // indirect
github.com/Azure/go-autorest/tracing v0.6.0 // indirect
github.com/AzureAD/microsoft-authentication-library-for-go v1.2.2 // indirect
github.com/AzureAD/microsoft-authentication-library-for-go v1.3.3 // indirect
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
github.com/dimchansky/utfbom v1.1.1 // indirect
github.com/envoyproxy/protoc-gen-validate v1.2.1 // indirect
Expand All @@ -50,10 +50,10 @@ require (
github.com/zeebo/bencode v1.0.0 // indirect
go.uber.org/multierr v1.11.0 // indirect
go.uber.org/zap v1.27.0 // indirect
golang.org/x/crypto v0.35.0 // indirect
golang.org/x/net v0.36.0 // indirect
golang.org/x/sys v0.30.0 // indirect
golang.org/x/text v0.22.0 // indirect
golang.org/x/crypto v0.36.0 // indirect
golang.org/x/net v0.38.0 // indirect
golang.org/x/sys v0.31.0 // indirect
golang.org/x/text v0.23.0 // indirect
google.golang.org/genproto/googleapis/api v0.0.0-20250106144421-5f5ef82da422 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20250115164207-1a7da9e5054f // indirect
google.golang.org/grpc v1.71.1 // indirect
Expand Down
Loading