Skip to content

Optional tracing in azblob #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2025
Merged

Optional tracing in azblob #134

merged 2 commits into from
Apr 16, 2025

Conversation

eccles
Copy link
Contributor

@eccles eccles commented Apr 11, 2025 •
edited
Loading 

Testing results

Inspected spans using 'task monitor:tracing' and check that a span 'listBlobsFlat' was present. This is only present if the injection logic has worked.


robot:smoke: RESULTS: Tests 96 , Errors 0 , Failures 0 , Time 50.470
robot:core: RESULTS: Tests 534 , Errors 0 , Failures 0 , Time 180.150
robot:tenancies: RESULTS: Tests 38 , Errors 0 , Failures 0 , Time 57.695
robot:invites: RESULTS: Tests 23 , Errors 0 , Failures 0 , Time 6.578
robot:scitt: RESULTS: Tests 8 , Errors 0 , Failures 0 , Time 141.083
robot:abac: RESULTS: Tests 196 , Errors 0 , Failures 0 , Time 153.159
robot:obac: RESULTS: Tests 117 , Errors 0 , Failures 0 , Time 251.570
robot:slow-cd: RESULTS: Tests 4 , Errors 0 , Failures 0 , Time 24.134
robot:flaky: RESULTS: Tests 4 , Errors 0 , Failures 0 , Time 11.542

playright:api:smoke:   30 passed (2.2m)
playright:api:core:   41 passed (16.5s)
playright:api:app-registrations:   44 passed (20.9s)
playright:api:membership:   69 passed (27.6s)
playright:api:tenancies:   61 passed (26.5s)

AB#10601

@eccles eccles force-pushed the dev/paul/10601-remove-tracing-from-azblob branch 6 times, most recently from 700fda1 to 08ed51e Compare April 14, 2025 13:52
@eccles eccles marked this pull request as ready for review April 14, 2025 14:50
@eccles eccles force-pushed the dev/paul/10601-remove-tracing-from-azblob branch 3 times, most recently from 29e4d51 to d7d746c Compare April 15, 2025 09:58
@eccles
Optional tracing in azblob
8dd176b 
azblob now only does tracing if an option is passed when
instantiating the the azblob.Storer or azblob.Reader
objects.

AB#10601

Signed-off-by: Paul Hewlett <phewlett76@gmail.com>
@eccles eccles force-pushed the dev/paul/10601-remove-tracing-from-azblob branch from d7d746c to 8dd176b Compare April 15, 2025 10:07
robinbryce
robinbryce reviewed Apr 15, 2025
View reviewed changes
robinbryce
robinbryce reviewed Apr 15, 2025
View reviewed changes
robinbryce
robinbryce reviewed Apr 15, 2025
View reviewed changes
robinbryce
robinbryce reviewed Apr 15, 2025
View reviewed changes
robinbryce
robinbryce previously approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@robinbryce robinbryce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please see comments regarding additional unconditional logging

robinbryce
robinbryce approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@robinbryce robinbryce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@eccles eccles merged commit b330ed6 into main Apr 16, 2025
3 checks passed
@eccles eccles deleted the dev/paul/10601-remove-tracing-from-azblob branch April 16, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinbryce robinbryce robinbryce approved these changes

@waarg waarg Awaiting requested review from waarg

@wp0pw wp0pw Awaiting requested review from wp0pw

@honourfish honourfish Awaiting requested review from honourfish

@j-hartley j-hartley Awaiting requested review from j-hartley

@landintrees landintrees Awaiting requested review from landintrees

@henry739 henry739 Awaiting requested review from henry739

@rcoxhill-01 rcoxhill-01 Awaiting requested review from rcoxhill-01

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eccles @robinbryce