This repository was archived by the owner on Nov 7, 2019. It is now read-only.
Enhanced Querying, "Submodel" Support #2
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings some necessary enhancements to make sql_datastore support a more "natural" implementation of the datastore.Query command. It also establishes patterns for doing one-to-many style relationships by leveraging Key Paths.
Here's an example from an upcoming
datatogether/archive
pull request:Breaking Changes
model.NewSQLModel(id string)
is nowmodel.NewSQLModel(key datastore.Key)
NewSQLModel used to be passed a string id value. The original intent behind this was to have consumers of the
sql_datastore
package do less work extracting Model ID's from keys. This turns out to not be enough information to support sub-model type relationships, where the parent ID is passed back in via the key path. So, this PR chances the interface to pass back the entire key. I think this is a better way to go.