Skip to content

Conversation

@erikson84
Copy link
Contributor

No description provided.

erikson84 and others added 4 commits January 31, 2020 09:23
Added 'br' option for brazilian portuguese.
Added 'br' language support.
@pvictor
Copy link
Collaborator

pvictor commented Feb 3, 2020

Thanks @erikson84 for the PR, I removed non-ASCII characters to avoid R CMD warnings, I think it's good now.

@bthieurmel
Copy link
Contributor

Hi @erikson84 and thanks for your PR.

Can you confirm or not that in fact this is more globally a Portuguese support or there is a some strong diffrence between Portuguese and Brazilian portuguese ?

@erikson84
Copy link
Contributor Author

@bthieurmel , most software packages distinguish between brazilian portuguese and portuguese. On the other hand, I believe a non-brazilian portuguese speaker would have no problem understanding the text.

@bthieurmel bthieurmel merged commit 3ca90da into datastorm-open:master Feb 28, 2020
@bthieurmel
Copy link
Contributor

bthieurmel commented Feb 28, 2020

Ok. So keep br. Now merge on master, and on CRAN soon.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants