-
Notifications
You must be signed in to change notification settings - Fork 552
PYTHON-1371 Throw a specific error for vector serialization failure cases #1193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caveat: I cannot access the jenkins server where the CI failure is shown.
Looking at the code, howewer, it would LGTM
hemidactylus
approved these changes
Dec 14, 2023
The CI failure is just
Looks good to me. |
SiyaoIsHiding
approved these changes
Dec 15, 2023
Test failures are all known issues, calling this good |
fruch
added a commit
to fruch/python-driver
that referenced
this pull request
Jun 6, 2024
…sync_with_upstream_3.29.1 version 3.29.0 * tag '3.29.0' of https://github.com/datastax/python-driver: Documentation (and other) updates for 3.29.0 (datastax#1194) PYTHON-1331 ssl.match_hostname() is deprecated in 3.7 (datastax#1191) PYTHON-1371 Add explicit exception type for serialization failures (datastax#1193) Remove outdated Python pre-3.7 references (datastax#1186) PYTHON-1368 Avoid installing DSE deps + executing DSE tests for Python 3.12 (datastax#1188) PYTHON-1366 Handle removal of asyncore in Python 3.12 (datastax#1187) Removed backup(.bak) files (datastax#1185) docs: Fix typo in add_callbacks (datastax#1177) Remove some remnants of Python2 (datastax#1172) PYTHON-1313 Fix asyncio removals in Python 3.10 (datastax#1179) PYTHON-1364 Fix ssl.wrap_socket errors (from eventlet) for Python 3.12 (datastax#1181) Add Jenkins support for Python 3.12.0 (datastax#1180) Update redirects in docs.yaml (datastax#1178) Jenkins using new python versions in the matrix (datastax#1174) Update docs.yaml to point to most recent 3.28.0 docs changes CONN-38 Notes for 3.28.0 on PYTHON-1350 (datastax#1167) Include docs for 3.28.0 Fixed non-valid rst in README
dkropachev
pushed a commit
to scylladb/python-driver
that referenced
this pull request
Jan 5, 2025
dkropachev
pushed a commit
to scylladb/python-driver
that referenced
this pull request
Jan 5, 2025
dkropachev
pushed a commit
to scylladb/python-driver
that referenced
this pull request
Jan 26, 2025
dkropachev
pushed a commit
to scylladb/python-driver
that referenced
this pull request
Feb 18, 2025
dkropachev
pushed a commit
to scylladb/python-driver
that referenced
this pull request
Feb 21, 2025
dkropachev
pushed a commit
to scylladb/python-driver
that referenced
this pull request
Feb 21, 2025
dkropachev
pushed a commit
to scylladb/python-driver
that referenced
this pull request
Feb 22, 2025
dkropachev
pushed a commit
to scylladb/python-driver
that referenced
this pull request
Feb 22, 2025
dkropachev
pushed a commit
to scylladb/python-driver
that referenced
this pull request
Feb 22, 2025
dkropachev
pushed a commit
to scylladb/python-driver
that referenced
this pull request
Feb 22, 2025
dkropachev
pushed a commit
to scylladb/python-driver
that referenced
this pull request
Feb 22, 2025
dkropachev
pushed a commit
to scylladb/python-driver
that referenced
this pull request
Feb 22, 2025
dkropachev
pushed a commit
to scylladb/python-driver
that referenced
this pull request
Feb 22, 2025
dkropachev
pushed a commit
to scylladb/python-driver
that referenced
this pull request
Feb 23, 2025
dkropachev
pushed a commit
to scylladb/python-driver
that referenced
this pull request
Feb 23, 2025
dkropachev
pushed a commit
to scylladb/python-driver
that referenced
this pull request
Feb 23, 2025
dkropachev
pushed a commit
to scylladb/python-driver
that referenced
this pull request
Feb 23, 2025
dkropachev
pushed a commit
to scylladb/python-driver
that referenced
this pull request
Feb 23, 2025
dkropachev
pushed a commit
to scylladb/python-driver
that referenced
this pull request
Feb 23, 2025
dkropachev
pushed a commit
to scylladb/python-driver
that referenced
this pull request
Feb 23, 2025
dkropachev
added a commit
to scylladb/python-driver
that referenced
this pull request
Feb 23, 2025
* PYTHON-1364 Fix ssl.wrap_socket errors (from eventlet) for Python 3.12 (datastax#1181) * PYTHON-1366 Handle removal of asyncore in Python 3.12 (datastax#1187) * Remove outdated Python pre-3.7 references (datastax#1186) * PYTHON-1371 Add explicit exception type for serialization failures (datastax#1193) * PYTHON-1331 ssl.match_hostname() is deprecated in 3.7 (datastax#1191) * Documentation (and other) updates for 3.29.0 (datastax#1194) * fix(test-requirements): remove python 3.13 restrictions Original commit c9b24b7 made it not install certain modules on python 3.13 because at the time python was broken and did not support these modules, now they work ok, roll it back. --------- Co-authored-by: Bret McGuire <absurdfarce@users.noreply.github.com> Co-authored-by: Brad Schoening <5796692+bschoening@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.