adding verification script - #712
Open
MarkWolters wants to merge 1 commit into
Open
Conversation
MarkWolters
requested review from
ashkrisk,
jshook and
tlwillke
as code owners
August 18, 2026 18:54
Contributor
|
Before you submit for review:
If you did not complete any of these, then please explain below. |
r-devulap
approved these changes
Aug 19, 2026
| fi | ||
|
|
||
| echo "-- exported symbols (nm) --" | ||
| REQUIRED_SYMBOLS=( |
Contributor
There was a problem hiding this comment.
Maybe add a comment explaining that an exhaustive list is not required here. Successful loading of the .so is sufficient, since the Java side will fail if any expected kernel API is missing. This would also clarify that the list does not need to be maintained as additional kernels are introduced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds one new script,
verify_native_lib.sh, to the jvector-native module. The purpose of this script is to verify that the libjvector.so shared library has been correctly generated and contains the expected content prior to pushing a release to Sonatype (although it can also be used ad hoc at any time).This PR contains no code changes or modifications to existing files.
Release instructions at https://github.com/riptano/VECTOR-SEARCH/blob/main/teamdocs/jvector_releases_admin.md have been updated to include a step for this check.