GraphIndexBuilder::addGraphNode must iterate all graph levels to estimate used bytes

[michaeljmarshall]

The current implementation for GraphIndexBuilder::addGraphNode has a bug in the byte estimation logic. It calls IntStream.range(0, nodeLevel.level), which in turn calls:

    public static IntStream range(int startInclusive, int endExclusive) {
        if (startInclusive >= endExclusive) {
            return empty();
        } else {
            return StreamSupport.intStream(
                    new Streams.RangeIntSpliterator(startInclusive, endExclusive, false), false);
        }
    }

This is problematic because the nodeLevel.level is inclusive while the right bound of the range is exclusive.

The end result is an estimate that systematically misses the numerically highest level of the graph, thereby under counting bytes used. In reviewing the IntStream api, it seems most appropriate to use the rangeClosed method to achieve the desired semantics.

[Copilot]

Pull Request Overview

Fixes a bug in GraphIndexBuilder::addGraphNode byte estimation logic where the highest graph level was systematically excluded from calculations due to using IntStream.range() with inclusive level values but exclusive upper bounds.

• Replaces IntStream.range() with IntStream.rangeClosed() to properly include all graph levels in byte calculations
• Adds a test case to verify the byte estimation correctness

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
GraphIndexBuilder.java	Changes IntStream.range to rangeClosed to fix inclusive level boundary issue
GraphIndexBuilderTest.java	Adds test case to verify byte estimation works correctly

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[marianotepper]

Good catch! Looks good.

[tlwillke]

Really nice catch indeed. LGTM