-
Notifications
You must be signed in to change notification settings - Fork 240
Add Prepare Request support to RequestTracker and OpenTelemetry extension #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b139126
to
d91f6a8
Compare
… to NodeRequestInfo, add PrepareRequest to NodeRequestInfo
I decided to rename |
I think it makes sense @joao-r-reis . It makes more clear what those objects are |
I'm happy that you found the time to support Prepared Statements. This is looking really good |
Those images are looking sweet. Btw, I just realized that we might have a problem regarding the Keyspace. The keyspace information only appears if its set in the |
I already knew this but I thought this is ok since the attribute is only required if it's available and you even added a test that verifies that this attribute is not there when the keyspace is not set in the session. I didn't test this but it is possible that for Prepared Statements the Keyspace will be there even if it is not set at the session level (but then again it's not that relevant since all we can do is set the attribute if the keyspace is there and not set it if it isn't) |
Oh, yeah, I forgot that I included that test. It seemed that made sense at the time and I think it's fine if the attribute is available when its set. |
Hi @joao-r-reis, we have plan to use this feature on our codebase, do you have a ETA for releasing the 3.22.0? |
3.22.0 is going out today |
cc @simaoribeiro
It's a draft PR because I'll have to rebase this when #613 is merged, then I'll remove the draft status