Skip to content

CSHARP-1003 Fix support for Astra custom domains in linux environments #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

joao-r-reis
Copy link
Collaborator

#600 added support for Astra custom domains but that implementation only works in Windows environments.

@joao-r-reis joao-r-reis added this to the 3.19.5 milestone Nov 22, 2023
Copy link
Collaborator

@absurdfarce absurdfarce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense given the platform-specific variation of this functionality. It's very strange to me that this behaviour varies at all by platform... but that's different than the concern of this PR.

@joao-r-reis
Copy link
Collaborator Author

Makes sense given the platform-specific variation of this functionality. It's very strange to me that this behaviour varies at all by platform... but that's different than the concern of this PR.

There's a new "official" library that parses asn.1 stuff that would make it possible to stop relying on formatting it as a string and then parsing it manually but that library is only available in a newer .NET version so we can't use it on our driver as it stands.

@joao-r-reis joao-r-reis merged commit 4a7143b into master Nov 27, 2023
@joao-r-reis joao-r-reis deleted the CSHARP-1003 branch November 27, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants