CPP-966 Compilation warnings after cass_set_use_hostname_resolution() marked as deprecated #551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Necessary to get newer versions of DSE running for tests.
…as well as any callers
…er version distinct in order to avoid confusion
absurdfarce
commented
Jul 28, 2023
| @@ -1491,7 +1491,7 @@ CCM::Bridge::generate_create_updateconf_command(CassVersion cassandra_version) { | |||
| updateconf_command.push_back("enable_scripted_user_defined_functions:true"); | |||
| } | |||
|
|
|||
| if (cassandra_version >= "4.0.0") { | |||
| if (cassandra_version >= "4.0.0" && !is_dse()) { | |||
There was a problem hiding this comment.
A small fix to get DSE working for integration tests. IIRC @weideng1 has something similar to this in another PR.
absurdfarce
commented
Jul 28, 2023
| get(), (enable == true ? cass_true : cass_false))); | ||
| return *this; | ||
| } | ||
|
|
There was a problem hiding this comment.
The heart of the matter. The use of this function was the immediate cause of the slew of deprecated warnings when building the integration tests.
absurdfarce
commented
Jul 28, 2023
| @@ -203,7 +202,6 @@ class AuthenticationTest : public DseIntegration { | |||
| Cluster cluster = dse::Cluster::build() | |||
| .with_plaintext_authenticator(username, password) | |||
| .with_contact_points(contact_points_) | |||
| .with_hostname_resolution(true) | |||
There was a problem hiding this comment.
These two usages are the only places where with_hostname_resolution() was actually used. Manually confirmed this test passes for all supported versions of DSE after this change.
weideng1
approved these changes
Jul 29, 2023
weideng1
pushed a commit
that referenced
this pull request
Jul 29, 2023
… marked as deprecated (#551) * Change ccm updateconf logic to not enable MV and UDF in the DSE case. Necessary to get newer versions of DSE running for tests. * Remove the offending function from the (test) cluster building logic as well as any callers * Remove beta protocol support from CLI options exposed via the integration tests * Remove beta protocol support from test cluster object as well * A drive-by fix: make the error messages for protocol version vs. server version distinct in order to avoid confusion
weideng1
pushed a commit
that referenced
this pull request
Aug 1, 2023
… marked as deprecated (#551) * Change ccm updateconf logic to not enable MV and UDF in the DSE case. Necessary to get newer versions of DSE running for tests. * Remove the offending function from the (test) cluster building logic as well as any callers * Remove beta protocol support from CLI options exposed via the integration tests * Remove beta protocol support from test cluster object as well * A drive-by fix: make the error messages for protocol version vs. server version distinct in order to avoid confusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with some other miscellaneous fixes as well: