[CFX-3720] Set up MacOS application notarization

.github/workflows/release.yaml

@@ -33,3 +33,8 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           HOMEBREW_TAPS_SSH_KEY: ${{ secrets.HOMEBREW_TAPS_SSH_KEY }}
+          MACOS_SIGN_P12: ${{ secrets.MACOS_SIGN_P12 }}
+          MACOS_SIGN_PASSWORD: ${{ secrets.MACOS_SIGN_PASSWORD }}
+          MACOS_NOTARY_ISSUER_ID: ${{ secrets.MACOS_NOTARY_ISSUER_ID }}
+          MACOS_NOTARY_KEY_ID: ${{ secrets.MACOS_NOTARY_KEY_ID }}
+          MACOS_NOTARY_KEY: ${{ secrets.MACOS_NOTARY_KEY }}

cmd/auth/login_test.go

@@ -30,6 +30,7 @@ func setupTestEnvironment(t *testing.T) (*httptest.Server, func()) {
 	require.NoError(t, err)
 
 	originalHome := os.Getenv("HOME")
+
 	os.Setenv("HOME", tempDir)
 
 	// Save original callback function.
@@ -62,6 +63,7 @@ func setupTestEnvironment(t *testing.T) (*httptest.Server, func()) {
 		}
 	}))
 	viper.Set(config.DataRobotURL, server.URL+"/api/v2")
+
 	err = config.CreateConfigFileDirIfNotExists()
 	require.NoError(t, err)
 
@@ -153,14 +155,17 @@ func TestEnsureAuthenticated_NoURL(t *testing.T) {
 	defer os.RemoveAll(tempDir)
 
 	originalHome := os.Getenv("HOME")
+
 	os.Setenv("HOME", tempDir)
 
 	defer os.Setenv("HOME", originalHome)
 
 	viper.Reset()
+
 	os.Unsetenv("DATAROBOT_ENDPOINT")
 	os.Unsetenv("DATAROBOT_API_TOKEN")
 	viper.Set(config.DataRobotURL, "")
+
 	baseURL := config.GetBaseURL()
 	assert.Empty(t, baseURL, "Expected GetBaseURL to return empty string")
 
@@ -202,6 +207,7 @@ func TestConfig_ConfigFilePath(t *testing.T) {
 	defer os.RemoveAll(tempDir)
 
 	originalHome := os.Getenv("HOME")
+
 	os.Setenv("HOME", tempDir)
 
 	defer os.Setenv("HOME", originalHome)

cmd/task/list/cmd.go

@@ -43,6 +43,7 @@ func Cmd() *cobra.Command {
 
 			if !runner.Installed() {
 				_, _ = fmt.Fprintln(os.Stderr, `"`+binaryName+`" binary not found in PATH. Please install Task from https://taskfile.dev/installation/`)
+
 				os.Exit(1)
 
 				return
@@ -51,6 +52,7 @@ func Cmd() *cobra.Command {
 			tasks, err := runner.ListTasks()
 			if err != nil {
 				_, _ = fmt.Fprintln(os.Stderr, "Error:", err)
+
 				os.Exit(1)
 
 				return

cmd/task/run/cmd.go

@@ -49,6 +49,7 @@ func Cmd() *cobra.Command {
 
 			if !runner.Installed() {
 				_, _ = fmt.Fprintln(os.Stderr, `"`+binaryName+`" binary not found in PATH. Please install Task from https://taskfile.dev/installation/`)
+
 				os.Exit(1)
 
 				return
@@ -74,6 +75,7 @@ func Cmd() *cobra.Command {
 				}
 
 				_, _ = fmt.Fprintln(os.Stderr, "Error:", err)
+
 				os.Exit(exitCode)
 			}
 		},

cmd/templates/setup/loginModel_test.go

@@ -83,6 +83,7 @@ func (suite *LoginModelTestSuite) AfterTest(suiteName, testName string) {
 	_, _ = suiteName, testName
 
 	os.RemoveAll(suite.tempDir) // Clean up the temporary directory after each test
+
 	dir, _ := os.MkdirTemp("", "datarobot-config-test")
 	suite.tempDir = dir
 	suite.T().Setenv("HOME", suite.tempDir)

goreleaser.yaml

@@ -102,3 +102,19 @@ homebrew_casks:
     commit_author:
       name: goreleaserbot
       email: bot@goreleaser.com
+
+notarize:
+  macos:
+    - enabled: '{{ isEnvSet "MACOS_SIGN_P12" }}'
+      ids: [darwin]
+      sign:
+        certificate: "{{ .Env.MACOS_SIGN_P12 }}"
+        password: "{{ .Env.MACOS_SIGN_PASSWORD }}"
+      notarize:
+        issuer_id: "{{.Env.MACOS_NOTARY_ISSUER_ID}}"
+        key_id: "{{.Env.MACOS_NOTARY_KEY_ID}}"
+        key: "{{.Env.MACOS_NOTARY_KEY}}"
+        # Whether to wait for the notarization to finish.
+        # Not recommended, as it could take a really long time.
+        wait: true
+        timeout: 20m

internal/config/auth.go

@@ -69,12 +69,14 @@ func SaveURLToConfig(newURL string) error {
 	if newURL == "" {
 		viper.Set(DataRobotURL, "")
 		viper.Set(DataRobotAPIKey, "")
+
 		_ = viper.WriteConfig()
 
 		return nil
 	}
 
 	viper.Set(DataRobotURL, newURL+"/api/v2")
+
 	_ = viper.WriteConfig()
 
 	return nil

internal/task/discovery.go

@@ -119,6 +119,7 @@ func ExitWithError(err error) {
 	}
 
 	_, _ = fmt.Fprintln(os.Stderr, "Error discovering tasks:", err)
+
 	os.Exit(1)
 }