UFAL/Update baseHref in the index.html for correct SSR fetching#944
UFAL/Update baseHref in the index.html for correct SSR fetching#944milanmajchrak merged 1 commit intodtq-devfrom
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughA new logic block was introduced in the server-side rendering callback within Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Server
participant Env
Client->>Server: Request page (SSR)
Server->>Server: Render page
Server->>Env: Get UI namespace env variable
Env-->>Server: Return value
Server->>Server: Compute baseHref, ensure trailing slash
Server->>Server: Replace <base href="..."> in HTML
Server-->>Client: Return modified HTML
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Problem description
Summary by CodeRabbit
<base href>tag is set accurately based on environment settings.