#808 - Redirect fix - switched href to routerLink

[jr-rk]

Phases	MP	MM	MB	MR	JM	Total
ETA	0	0	0	0	0	0
Developing	0	0	0	0	0	0
Review	0	0	0	0	0	0
Total	-	-	-	-	-	0
ETA est.						0
ETA cust.	-	-	-	-	-	0

Testing

To test changes on localhost, it is helpful to add these lines from config.example.yml with nameSpace: /repository to config.yml

[coderabbitai]

Walkthrough

The update modifies the navigation mechanism in an Angular HTML template. The anchor tag in the item-license-mapper.component.html file now uses the routerLink directive instead of the traditional href attribute. This change leverages Angular's client-side routing to handle navigation without a full page reload.

Changes

File	Change Summary
src/app/.../item-license-mapper.component.html	Replaced the href attribute with the routerLink directive to use Angular's routing mechanism for navigation.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant A as Anchor Element
    participant R as Angular Router
    participant V as View Component

    U->>A: Click on navigation link
    A-->>R: Triggers navigation via routerLink
    R->>V: Loads the target component (view)

Loading

Poem

I'm a rabbit, hopping with glee,
A new routerLink makes code free.
No page reloads, smooth as can be,
Angular routes, setting our UI free.
Hop along, my friends, in each line of spree!
🐇🌟

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/app/item-page/edit-item-page/item-license-mapper/item-license-mapper.component.html (1)

29-32: Switching to routerLink for internal navigation is a good move.
Replacing the traditional href with [routerLink] leverages Angular’s client-side routing and avoids full page reloads. Please ensure that the concatenation of getLicensesModulePath() and getLicensesManageTablePath() produces the correct route. As an optional improvement, consider using the array syntax (e.g. [routerLink]="[getLicensesModulePath(), getLicensesManageTablePath()]") if your routes contain multiple segments or need clearer separation.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c73814a and 0153767.

📒 Files selected for processing (1)

• src/app/item-page/edit-item-page/item-license-mapper/item-license-mapper.component.html (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: dspace-angular / docker-build (linux/amd64, ubuntu-latest, true)
• GitHub Check: tests (18.x)
• GitHub Check: tests (16.x)

[jr-rk]

To test changes on localhost, it is helpful to add these lines from config.example.yml with nameSpace: /repository to config.yml