UFAL/Fix downloads curl feature - unit test#1224
Merged
milanmajchrak merged 1 commit intodtq-devfrom Feb 26, 2026
Merged
Conversation
…imer on Node 18.x
There was a problem hiding this comment.
Pull request overview
Updates a unit test for the CC license submission section to correctly handle the component’s debounced behavior, avoiding timer leakage between tests.
Changes:
- Wrap the “license selected” setup in a
fakeAsynczone. - Advance virtual time with
tick(300)to flush thedebounceTime(300)pipeline before assertions run.
src/app/submission/sections/cc-license/submission-section-cc-licenses.component.spec.ts
Show resolved
Hide resolved
src/app/submission/sections/cc-license/submission-section-cc-licenses.component.spec.ts
Show resolved
Hide resolved
src/app/submission/sections/cc-license/submission-section-cc-licenses.component.spec.ts
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
Analysis
(Write here, if there is needed describe some specific problem. Erase it, when it is not needed.)
Problems
(Write here, if some unexpected problems occur during solving issues. Erase it, when it is not needed.)
Sync verification
If en.json5 or cs.json5 translation files were updated:
yarn run sync-i18n -t src/assets/i18n/cs.json5 -ito synchronize messages, and changes are included in this PR.Manual Testing (if applicable)
Copilot review