ZCU-DATA/filter config.json before exposing it#1068
Merged
milanmajchrak merged 2 commits intocustomer/zcu-datafrom Oct 31, 2025
Merged
ZCU-DATA/filter config.json before exposing it#1068milanmajchrak merged 2 commits intocustomer/zcu-datafrom
milanmajchrak merged 2 commits intocustomer/zcu-datafrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a security improvement by sanitizing the configuration data exposed to the frontend. Instead of writing the entire appConfig object to the public config file, it creates a filtered publicConfig object that only includes client-side configuration properties.
Key Changes:
- Created a sanitized
publicConfigobject that explicitly includes only necessary frontend properties - Excluded server-side sensitive configuration (UI server host/port/ssl, REST server host/port/ssl, rate limiter settings, actuators config)
- Maintained all frontend-required features (themes, languages, forms, submission, etc.)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
Eliminating the security risk of exposing sensitive server-side configuration data to the frontend, by filtering the config object to only include client-necessary settings before writing to config.json.
based on #1067