Merged
Conversation
…ce dataquest/dspace-angular and the full image will go into dataquest/dspace-angular-dev
milanmajchrak
previously approved these changes
Oct 9, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes Docker image sizes by introducing a production-ready minified image configuration and reorganizing the build pipeline to support both development and production images.
- Adds memory optimization for Angular builds in the production Dockerfile
- Reconfigures GitHub workflow to build both development and production Docker images
- Updates image naming convention where the minified image replaces the main image and the full image becomes the development variant
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Dockerfile.dist | Adds NODE_OPTIONS environment variable to increase memory limit for Angular production builds |
| .github/workflows/docker.yml | Updates workflow to build both dev and production images with proper naming and removes disabled dist build |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
vidiecan
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
both dockerfiles are now pushed to docker hub, the smaller will replace dataquest/dspace-angular and the full image will go into dataquest/dspace-angular-dev
issue: https://github.com/dataquest-dev/dspace-customers/issues/343
Problem description
Reported issues
Not-reported issues
Analysis
(Write here, if there is needed describe some specific problem. Erase it, when it is not needed.)
Problems
(Write here, if some unexpected problems occur during solving issues. Erase it, when it is not needed.)