VSB-TUO/Highlight actual option in dropdown menu#1012
Merged
milanmajchrak merged 1 commit intocustomer/vsb-tuofrom Sep 26, 2025
Merged
VSB-TUO/Highlight actual option in dropdown menu#1012milanmajchrak merged 1 commit intocustomer/vsb-tuofrom
milanmajchrak merged 1 commit intocustomer/vsb-tuofrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the dropdown menu highlighting behavior to show the actual selected option instead of defaulting to the first item. It addresses the issue where the dropdown would highlight the first option regardless of the current form value.
- Adds logic to determine the correct index for the currently selected value
- Updates the HTML template to properly highlight the active option based on current value
- Improves user experience by providing visual feedback for the selected option
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| dynamic-scrollable-dropdown.component.ts | Adds getIndexForCurrentValue() method and updates selectedIndex logic to highlight the correct option |
| dynamic-scrollable-dropdown.component.html | Updates the active class condition to properly highlight the current value |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...der/ds-dynamic-form-ui/models/scrollable-dropdown/dynamic-scrollable-dropdown.component.html
Show resolved
Hide resolved
...ilder/ds-dynamic-form-ui/models/scrollable-dropdown/dynamic-scrollable-dropdown.component.ts
Show resolved
Hide resolved
Kasinhou
added a commit
that referenced
this pull request
Oct 9, 2025
Co-authored-by: Matus Kasak <matus.kasak@dataquest.sk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
Reported issues
Not-reported issues
Analysis
(Write here, if there is needed describe some specific problem. Erase it, when it is not needed.)
Problems
Linked issue: #1010