UFAL/Submission autocomplete search is case sensitive

[Paurikova2]

Phases	MP	MM	MB	MR	JM	Total
ETA	0	0	0	0	0	0
Developing	13	0	0	0	0	0
Review	0	0	0	0	0	0
Total	-	-	-	-	-	0
ETA est.						0
ETA cust.	-	-	-	-	-	0

Problem description

When Solr generates suggestions, the input "mil" returns "Maximilan", and "Mil" returns "Milan". However, we need "mil" to also return "Milan" — but not for "Mil" to return "Maximilan".

Summary by CodeRabbit

• Bug Fixes
  • Improved suggestion filtering to be case-insensitive, enhancing search accuracy.
• Tests
  • Added integration tests to ensure suggestions work correctly regardless of case in search queries.

[coderabbitai]

Walkthrough

The filtering logic in the processSolrSearchResults method of the Suggestion REST controller was updated to perform case-insensitive substring matching. Two new integration test methods were added to verify that the suggestion search correctly handles case-insensitive queries against the Solr title_ac index.

Changes

File(s)	Change Summary
dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/SuggestionRestController.java	Modified processSolrSearchResults to use lowercase comparison for substring filtering, enabling case-insensitive suggestion matching.
dspace-server-webapp/src/test/java/org/dspace/app/rest/SuggestionRestControllerIT.java	Added two integration tests verifying case-insensitive suggestion retrieval from Solr, including tests with predefined and newly created items.

Poem

A bunny hopped through code today,
Adjusted filters in a gentle way.
Now searches find what once was missed,
No matter if the case is switched.
Tests confirm the leap is right—
More matches found, both day and night!
🐇✨

Tip

⚡️ Faster reviews with caching

• CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3a9fde5 and 1a1d6a5.

📒 Files selected for processing (1)

• dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/SuggestionRestController.java (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/SuggestionRestController.java

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: dspace-dependencies / docker-build (linux/amd64, ubuntu-latest, true)
• GitHub Check: Run Integration Tests
• GitHub Check: Run Unit Tests

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Paurikova2]

@milanmajchrak I added it also to test scenarios