Merged
Conversation
Closed
3 tasks
milanmajchrak
requested changes
Aug 5, 2024
|
|
||
| /** | ||
| * Database entity representation of the previewcontent table. | ||
| * Database entity representation of class FileInfo. |
Collaborator
There was a problem hiding this comment.
So this is a database entity representation of what?
dspace-api/src/main/java/org/dspace/content/PreviewContent.java
Outdated
Show resolved
Hide resolved
| ALTER TABLE eperson ADD welcome_info varchar(30); | ||
|
|
||
| ALTER TABLE eperson ADD can_edit_submission_metadata BOOL; No newline at end of file | ||
| ALTER TABLE eperson ADD can_edit_submission_metadata BOOL; |
Collaborator
There was a problem hiding this comment.
Please add this changes into a new file called e.g., V7.6.1._2024.08.05_Added_Preview_Tables.sql
| CREATE TABLE previewcontent ( | ||
| previewcontent_id integer NOT NULL, | ||
| bitstream_id uuid NOT NULL, | ||
| name varchar(256), |
| ALTER TABLE eperson ADD welcome_info varchar(30); | ||
|
|
||
| ALTER TABLE eperson ADD can_edit_submission_metadata BOOL; | ||
|
|
Collaborator
There was a problem hiding this comment.
Please change the name of the file
| } else { | ||
| String data = ""; | ||
| if (bitstream.getFormat(context).getExtensions().contains("zip")) { | ||
| if (bitstream.getFormat(context).getMIMEType().equals("application/zip")) { |
Collaborator
There was a problem hiding this comment.
I remember, that we should check it following the getExtensions because of some reason I do not remember. Please can we check it like that again?
Collaborator
Author
There was a problem hiding this comment.
I don't understand your comment....
...server-webapp/src/main/java/org/dspace/app/rest/repository/PreviewContentRestRepository.java
Show resolved
Hide resolved
| try { | ||
| previewContent = previewContentService.find(context, integer); | ||
| } catch (SQLException e) { | ||
| throw new RuntimeException(e.getMessage(), e); |
Collaborator
There was a problem hiding this comment.
Maybe add some log error
dspace-server-webapp/src/test/java/org/dspace/app/rest/PreviewContentServiceImplIT.java
Show resolved
Hide resolved
dspace/config/clarin-dspace.cfg
Outdated
| @@ -1,4 +1,5 @@ | |||
| ## File for changes to dspace.cfg - separated from original configuration file to see what we changed | |||
| ## File for changes to dspace.cfg - separated from original configuration file to see what we changed | |||
Collaborator
There was a problem hiding this comment.
You've added the same comment twice
milanmajchrak
approved these changes
Aug 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
Notes: There is a different order.
