Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the log4j2 configuration files to enable automatic compression of rotated log files and removes unused sample deletion policy comments. The changes add .gz extensions to log file patterns across all appenders, which will cause Log4j2 to automatically compress rotated logs, saving disk space.
- Added
.gzextension to allfilePatternattributes to enable automatic compression of rotated logs - Removed commented-out sample deletion policy code blocks to clean up configuration files
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dspace/config/log4j2.xml | Updated 4 appenders (A1, A2, A3, A4) to compress rotated logs and removed 2 commented deletion policy examples |
| dspace/config/log4j2-handle-plugin.xml | Updated handle plugin appender (A1) to compress rotated logs and removed commented deletion policy example |
| dspace/config/log4j2-cli.xml | Updated 2 CLI appenders (A1, A2) to compress rotated logs and removed 2 commented deletion policy examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vidiecan
requested changes
Nov 19, 2025
vidiecan
left a comment
vidiecan
left a comment
There was a problem hiding this comment.
is this really what we want? I wanted .log and after 30 days gzip it
vidiecan
approved these changes
Nov 25, 2025
vidiecan
left a comment
vidiecan
left a comment
There was a problem hiding this comment.
still obsolete or 0 information comments
milanmajchrak
added a commit
that referenced
this pull request
Nov 26, 2025
* Gzipped files on rotating and do not delete files after 30 days * Updated solr logs - gzip, configured postgres logs to gzip after 1 day * Renamed log configuration file and updated comments
milanmajchrak
added a commit
that referenced
this pull request
Nov 26, 2025
Paurikova2
added a commit
that referenced
this pull request
Jan 8, 2026
Paurikova2
pushed a commit
that referenced
this pull request
Jan 8, 2026
* Gzipped files on rotating and do not delete files after 30 days * Updated solr logs - gzip, configured postgres logs to gzip after 1 day * Renamed log configuration file and updated comments
Paurikova2
pushed a commit
that referenced
this pull request
Jan 8, 2026
Paurikova2
pushed a commit
that referenced
this pull request
Jan 8, 2026
Paurikova2
pushed a commit
that referenced
this pull request
Jan 8, 2026
Paurikova2
pushed a commit
that referenced
this pull request
Jan 8, 2026
* Gzipped files on rotating and do not delete files after 30 days * Updated solr logs - gzip, configured postgres logs to gzip after 1 day * Renamed log configuration file and updated comments
milanmajchrak
added a commit
that referenced
this pull request
Jan 8, 2026
* cherrypick from dtq-dev #1160 * removed log.properties.conf from dockerfile --------- Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com>
milanmajchrak
added a commit
that referenced
this pull request
Jan 8, 2026
* cherrypick from dtq-dev #1160 * removed changes from dockerfile * removed files which we don't need --------- Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com>
milanmajchrak
added a commit
that referenced
this pull request
Jan 8, 2026
* cherrypick from dtq-dev #1160 * removed log.properties.conf from dockerfile --------- Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com>
milanmajchrak
added a commit
that referenced
this pull request
Jan 8, 2026
* cherrypick from dtq-dev #1160 * removed log.properties.conf from dockerfile --------- Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com>
milanmajchrak
added a commit
that referenced
this pull request
Jan 8, 2026
* Gzipped files on rotating and do not delete files after 30 days * Updated solr logs - gzip, configured postgres logs to gzip after 1 day * Renamed log configuration file and updated comments Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com>
milanmajchrak
added a commit
that referenced
this pull request
Jan 8, 2026
* Updated log rotating (#1160) * Gzipped files on rotating and do not delete files after 30 days * Updated solr logs - gzip, configured postgres logs to gzip after 1 day * Renamed log configuration file and updated comments * removed from dockerfile creating of log directly and its copying --------- Co-authored-by: milanmajchrak <90026355+milanmajchrak@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
Related :PR: https://github.com/dataquest-dev/dspace-angular/pull/1104/files
Analysis
(Write here, if there is needed describe some specific problem. Erase it, when it is not needed.)
Problems
(Write here, if some unexpected problems occur during solving issues. Erase it, when it is not needed.)
Manual Testing (if applicable)
Copilot review